[PATCH] D87705: [PowerPC] Implement Set Boolean Condition Instructions

[Lei Huang via Phabricator via llvm-commits]

lei added a comment.

For the p10 specific tests, I think just use the default CHECK vs CHECK-P10.
Also, please ensure we are testing on both BE and LE.



================
Comment at: llvm/test/CodeGen/PowerPC/CompareEliminationSpillIssue.ll:17
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | \
+; RUN: FileCheck %s --check-prefix=CHECK-P10
 @glob = local_unnamed_addr global i64 0, align 8
----------------
nit: indentation


================
Comment at: llvm/test/CodeGen/PowerPC/crbits.ll:4
+; RUN: llc -ppc-gpr-icmps=all -mtriple=powerpc64-unknown-linux-gnu \
+; RUN:      -verify-machineinstrs -mcpu=pwr7 -ppc-gen-isel=false < %s | \
+; RUN:      FileCheck --check-prefix=CHECK-NO-ISEL %s
----------------
nit: indentation


================
Comment at: llvm/test/CodeGen/PowerPC/crbits.ll:9
+; RUN:     FileCheck %s --check-prefix=CHECK-P10
 
 ; Function Attrs: nounwind readnone
----------------
Do we not need a run line to test LE?


================
Comment at: llvm/test/CodeGen/PowerPC/p10-setbc-ri.ll:4
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | FileCheck %s \
+; RUN:     --check-prefix=CHECK-P10
+
----------------
BE test?
Since this is specifically written for P10, maybe just use the default CHECK instead of CHECK-P10.


================
Comment at: llvm/test/CodeGen/PowerPC/p10-setbc-rr.ll:4
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | FileCheck %s \
+; RUN:     --check-prefix=CHECK-P10
+
----------------
same.


================
Comment at: llvm/test/CodeGen/PowerPC/testComparesi32leu.ll:15
+; RUN:   FileCheck %s --check-prefix=CHECK-P10 --implicit-check-not cmpw \
+; RUN:   --implicit-check-not cmpd --implicit-check-not cmpl
 
----------------
I am not sure what this line is verifying.  The `--implicit-check-not` identicates it's making sure that we are not generating p8/p9 set boolean instructions since it's checking for `cmpw` and not `cmplw` which is generated for P10.  However, the run line does not contain the option to turn on integer compare codegen ...


================
Comment at: llvm/test/CodeGen/PowerPC/testComparesi32ltu.ll:10
 ; RUN:  --check-prefixes=CHECK,LE
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu -O2 \
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | \
----------------
Do we want to add and tests for integer compare codegen on P10?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87705/new/

https://reviews.llvm.org/D87705