[PATCH] D89941: [DebugInfo] Clear subreg in setDebugValueUndef()

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 05:16:52 PDT 2020


djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.

This looks reasonable to me.

(some nits included)



================
Comment at: llvm/test/DebugInfo/MIR/X86/machinesink-subreg.mir:23
+  ; Function Attrs: nounwind readnone
+  declare void @llvm.dbg.value(metadata, i64, metadata, metadata)
+
----------------
unused, it can be deleted


================
Comment at: llvm/test/DebugInfo/MIR/X86/machinesink-subreg.mir:64
+    ; DBG_VALUE should be left behind though. Verify that the sub-register
+    ; idex in the DBG_VALUE is cleared.
+    ; CHECK-LABEL: bb.0.entry:
----------------
idex --> index


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89941/new/

https://reviews.llvm.org/D89941



More information about the llvm-commits mailing list