[PATCH] D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block

[Momchil Velikov via Phabricator via llvm-commits]

chill marked an inline comment as done.
chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5730
+    // Check defs of LR.
+    if (MI.modifiesRegister(ARM::LR, nullptr))
+      Live = false;
----------------
efriedma wrote:
> chill wrote:
> > yroux wrote:
> > > I think we can get ride of passing nullptr since it is TRI default value in the prototype
> > One would think so, wouldn't they? :D 
> > 
> > I created D89625
> If you omit TRI, you'll miss defs of super-registers of LR.  I'm not sure there are any at the moment, but there are for other GPRs.
Fair enough, there are odd/even GPR pairs that do not include `LR`,  but I wouldn't  write off the possibility of `LR` being part of a super-register in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89189/new/

https://reviews.llvm.org/D89189