[PATCH] D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 05:03:00 PDT 2020


andrewng updated this revision to Diff 299925.
andrewng edited the summary of this revision.
andrewng added a comment.

Updated to address review comments and updated to add better testing. Whilst adding this testing, found another bug in the detection code; it was also not accounting for the size of the file signature!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89891/new/

https://reviews.llvm.org/D89891

Files:
  llvm/lib/Object/ArchiveWriter.cpp
  llvm/test/Object/archive-symtab.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89891.299925.patch
Type: text/x-patch
Size: 6967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201022/9b6d4556/attachment.bin>


More information about the llvm-commits mailing list