[PATCH] D89775: [lld][ELF][test] Add additional test coverage for LTO

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 04:39:26 PDT 2020


jhenderson added inline comments.


================
Comment at: lld/test/ELF/lto/bitcode-wrapper.ll:27
+
+; ERR1: error: [[FILE]]: Invalid bitcode wrapper header
+
----------------
grimar wrote:
> aside: we probably want to lowercase this message.
I took a quick look, and this is just one of several error messages within the BitcodeReader and BitcodeAnalyzer files, and most of them use upper-case, so that would probably want to be part of a much wider change. Think we'd need to discuss the preferred style of the library with whoever owns/maintains it before doing that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89775/new/

https://reviews.llvm.org/D89775



More information about the llvm-commits mailing list