[PATCH] D89379: [llvm-readobj/libObject] - Allow dumping objects that has a broken SHT_SYMTAB_SHNDX section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 01:35:10 PDT 2020


grimar planned changes to this revision.
grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:697
                                       const Elf_Shdr *SymTab) const {
+  assert(false);
+  ArrayRef<Elf_Word> ShndxTable;
----------------
jhenderson wrote:
> Debugging code needs removing?
Oops.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/ARM/dwarf-cfi.s:1-2
-# RUN: llvm-mc -triple arm-linux -filetype obj -o - %s | llvm-readobj -u - | FileCheck %s
+# RUN: llvm-mc -triple arm-linux -filetype obj %s -o %t
+# RUN: llvm-readobj -u %t | FileCheck %s
 
----------------
jhenderson wrote:
> Looks like you don't need to do this as part of this change, since this file is otherwise unaffected?
Right. I think I forgot to revert changes I did for debugging..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89379/new/

https://reviews.llvm.org/D89379



More information about the llvm-commits mailing list