[PATCH] D67626: [IR] Merge metadata manipulation code into Value

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added a comment.

In D67626#2336710 <https://reviews.llvm.org/D67626#2336710>, @dexonsmith wrote:

> Sadly I completely missed your update here. I’m skeptical there’s another `Value` subclass that needs or should have metadata (do you have something in mind?), but this is nevertheless a massive simplification and I like the direction!

Thank you for feedback!

This change was created to support attributes of basic blocks. They would mark blocks were specific floating point options are in effect and prevent floating point operations from moving between blocks with different FP properties. This idea was not supported by the community, so I agree, no new `Value` need metadata support. If however this patch could made the code a little better, it would be nice.

> If you’re still interested in pursuing this, please change the members you added to `Value` not to be public; you can make them protected and then in `Instruction` and `GlobalObject` I suggest adding `using` declarations. If a third category arises we can do the same there.

Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67626/new/

https://reviews.llvm.org/D67626