[PATCH] D89823: [AArch64][GlobalISel] Move imm adjustment for G_ICMP to post-legalizer lowering

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp:519-520
+    MatchInfo = *MaybeNewImmAndPred;
+    errs() << "Optimizing: ";
+    MI.dump();
+    return true;
----------------
debug left


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/select-arith-immed-compare.mir:31
-    %1:gpr(s32) = G_CONSTANT i32 4097
-    %4:gpr(s32) = G_ICMP intpred(slt), %0(s32), %1
-    %5:gpr(s32) = G_CONSTANT i32 1
----------------
Can we have some end-to-end tests that show that the MIR that we previously had being selected to CSINCWr still selects to the same output if we now go through lowering->select? Don't have to cover all the cases but to show the mechanism still works.

Maybe we'll need to use .ll tests for this, not sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89823/new/

https://reviews.llvm.org/D89823