[PATCH] D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang accepted this revision.
steven.zhang added a comment.

LGTM now.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1412
+
+let mayLoad = 1, mayStore = 0, hasSideEffects = 0, Predicates = [PairedVectorMemops, PrefixInstrs] in {
+  defm PLXVP :
----------------
steven.zhang wrote:
> NeHuang wrote:
> > steven.zhang wrote:
> > > I don't think there is any semantics difference with this change except that, we clear the sideeffect bit for PLXVP, which is not relative with what you want to do. 
> > Agree. Removed `hasSideEffects`.
> So, do we need to change these lines any more?
Well, it is needed as the different predicates. In fact, what we need to do is just to change the predicates. But it is up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89727/new/

https://reviews.llvm.org/D89727