[PATCH] D89846: [NFC][PowerPC] Move the folding RLWINMs from ppc-mi-peephole to PPCInstrInfo.
ChenZheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 21 18:18:24 PDT 2020
shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.
Thanks for trying to extend it for post-RA. This makes sense to me as some RLWINM will be generated after RA. One nit and please also fix the lint suggestions.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3192
+bool PPCInstrInfo::combineRLWINM(MachineInstr &MI,
+ MachineInstr **ToErase) const {
----------------
I think a more general name for this function would be better for later extension? For example `simplifyRotateAndMaskInstr()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89846/new/
https://reviews.llvm.org/D89846
More information about the llvm-commits
mailing list