[PATCH] D89826: [FunctionAttrs][NPM] Fix handling of convergent

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added reviewers: efriedma, nhaehnle, arsenm.
jdoerfert added a comment.
Herald added a subscriber: wdng.

Before I look at the changes in more detail, two high level comments, one we need to address actually. (And more people).

1. I find this sentence troublesome: `This is particularly useful on indirect calls; without this we may treat such calls as though the target is non-convergent.` We should say we do treat them or we don't, but not we `may`. That said, I am unsure if treating indirect calls as non-convergent regardless of what the function is is a good idea. `auto t = (&barrier); t();` seems to be the minimal example to make my point.
2. I would encourage someone that cares about convergent (which in theory includes me but not *right now*) to add this deduction to the Attributor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89826/new/

https://reviews.llvm.org/D89826