[PATCH] D89768: [Coroutine] Properly determine whether an alloca should live on the frame

[Xun Li via Phabricator via llvm-commits]

lxfind added a comment.

In D89768#2345916 <https://reviews.llvm.org/D89768#2345916>, @rjmccall wrote:

> Okay.  Well, it does seem to me that we need to be considering lifetimes.  If we can also optimize when we don't have lifetime information and the variable doesn't escape, that's great, but we often have pretty good lifetime information that we can use.  And in optimized builds we'll usually have already eliminated allocas that don't escape, so the remaining allocas are very likely to have all escaped.

Yes we are considering lifetimes. The algorithms by first checking to see if there are lifetimes, and if there are use them. After that we use the pointer visitor to do more precise tracking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89768/new/

https://reviews.llvm.org/D89768