[PATCH] D89810: [mem2reg] Remove dbg.values describing contents of dead allocas

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, lgtm.

In D89810#2343831 <https://reviews.llvm.org/D89810#2343831>, @Orlando wrote:

> Hi @vsk, thanks for taking a look, I'll address your inline comments shortly.
>
> On the topic of stale values after inlining+DSE: Could we teach the inliner to insert dbg.values in the same pattern as LowerDbgDeclare for parameters which are pointers to caller-local allocas?

That sounds  like a neat solution. I can't think of any issues with this, but it's probably worth a wider discussion (perhaps on a bugzilla PR or on llvm-dev).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89810/new/

https://reviews.llvm.org/D89810