[llvm] cb319b1 - [NFC][OpenMP] Update description of OMPGridValues enums
Saiyedul Islam via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 21 11:22:59 PDT 2020
Author: Saiyedul Islam
Date: 2020-10-21T18:22:11Z
New Revision: cb319b1b5d9346a67c2f2a829d3dace58dff5861
URL: https://github.com/llvm/llvm-project/commit/cb319b1b5d9346a67c2f2a829d3dace58dff5861
DIFF: https://github.com/llvm/llvm-project/commit/cb319b1b5d9346a67c2f2a829d3dace58dff5861.diff
LOG: [NFC][OpenMP] Update description of OMPGridValues enums
Update comments describing how OMPGridValues enums will be used in
clang, deviceRTLs, and hsa and cuda plugins.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D86232
Added:
Modified:
llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h b/llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h
index 41827181e30c..6b48cc447e13 100644
--- a/llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h
+++ b/llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h
@@ -28,29 +28,30 @@ namespace omp {
/// use the new array name.
///
/// Example usage in clang:
-/// const unsigned slot_size = ctx.GetTargetInfo().getGridValue(GV_Warp_Size);
+/// const unsigned slot_size =
+/// ctx.GetTargetInfo().getGridValue(llvm::omp::GVIDX::GV_Warp_Size);
///
/// Example usage in libomptarget/deviceRTLs:
-/// #include "OMPGridValues.h"
+/// #include "llvm/Frontend/OpenMP/OMPGridValues.h"
/// #ifdef __AMDGPU__
/// #define GRIDVAL AMDGPUGpuGridValues
/// #else
/// #define GRIDVAL NVPTXGpuGridValues
/// #endif
/// ... Then use this reference for GV_Warp_Size in the deviceRTL source.
-/// GRIDVAL[GV_Warp_Size]
+/// llvm::omp::GRIDVAL[llvm::omp::GVIDX::GV_Warp_Size]
///
/// Example usage in libomptarget hsa plugin:
-/// #include "OMPGridValues.h"
+/// #include "llvm/Frontend/OpenMP/OMPGridValues.h"
/// #define GRIDVAL AMDGPUGpuGridValues
/// ... Then use this reference to access GV_Warp_Size in the hsa plugin.
-/// GRIDVAL[GV_Warp_Size]
+/// llvm::omp::GRIDVAL[llvm::omp::GVIDX::GV_Warp_Size]
///
/// Example usage in libomptarget cuda plugin:
-/// #include "OMPGridValues.h"
+/// #include "llvm/Frontend/OpenMP/OMPGridValues.h"
/// #define GRIDVAL NVPTXGpuGridValues
/// ... Then use this reference to access GV_Warp_Size in the cuda plugin.
-/// GRIDVAL[GV_Warp_Size]
+/// llvm::omp::GRIDVAL[llvm::omp::GVIDX::GV_Warp_Size]
///
enum GVIDX {
/// The maximum number of workers in a kernel.
More information about the llvm-commits
mailing list