[PATCH] D89665: [LSR] ignore profitable chain optimization when instruction number is the major cost

[Sam Parker via Phabricator via llvm-commits]

samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Having separate loops sounds good to me, but please remove the extra conditional before committing. Thanks.



================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:2862
+  // chain as profitable.
   if (TTI.isProfitableLSRChainElement(Chain.Incs[0].UserInst))
     return true;
----------------
You don't need this now :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89665/new/

https://reviews.llvm.org/D89665