[PATCH] D89876: [ARM][SchedModels] Convert few cortex-a57 predicates to MCSchedPredicate

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

Hi Eugene,

could you please upload a diff with the full context?

Do you know why `isAddrMode3OpMinusReg` and `isAddrMode3OpImm` are not declared as static members of `ARMBaseInstrInfo`?
It seems to me that those should be static. I am asking this question because there may be better ways to implement this patch without having to touch the predicate expander.
Most of the checks performed by those predicates are just checking if operands are registers or specific immediate values. We already have specialised predicates for describing constraints on register operands and immediate operands. I would personally use `CheckFunctionPredicate` only as a last resort, if there is no other way to express the same predicate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89876/new/

https://reviews.llvm.org/D89876