[PATCH] D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions
Victor Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 21 07:24:18 PDT 2020
NeHuang marked 4 inline comments as done.
NeHuang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1412
+
+let mayLoad = 1, mayStore = 0, hasSideEffects = 0, Predicates = [PairedVectorMemops, PrefixInstrs] in {
+ defm PLXVP :
----------------
steven.zhang wrote:
> I don't think there is any semantics difference with this change except that, we clear the sideeffect bit for PLXVP, which is not relative with what you want to do.
Agree. Removed `hasSideEffects`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89727/new/
https://reviews.llvm.org/D89727
More information about the llvm-commits
mailing list