[PATCH] D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 06:23:42 PDT 2020


avl updated this revision to Diff 299664.
avl added a comment.

addressed comments: renamed files, added doxygen comments into library headers(except CopyConfig.h).

I propose to go ahead with this patch and continue with follow-up patches:

1. Remove Buffer.h/Buffer.cpp.
2. cleanup CopyConfig.h.
3. remove handling of SplitDWO from the library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88827/new/

https://reviews.llvm.org/D88827

Files:
  llvm/include/llvm/ObjCopy/Buffer.h
  llvm/include/llvm/ObjCopy/COFF/COFFObjcopy.h
  llvm/include/llvm/ObjCopy/CopyConfig.h
  llvm/include/llvm/ObjCopy/ELF/ELFConfig.h
  llvm/include/llvm/ObjCopy/ELF/ELFObjcopy.h
  llvm/include/llvm/ObjCopy/MachO/MachOObjcopy.h
  llvm/include/llvm/ObjCopy/ObjCopy.h
  llvm/include/llvm/ObjCopy/wasm/WasmObjcopy.h
  llvm/lib/CMakeLists.txt
  llvm/lib/LLVMBuild.txt
  llvm/lib/ObjCopy/Buffer.cpp
  llvm/lib/ObjCopy/CMakeLists.txt
  llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp
  llvm/lib/ObjCopy/COFF/COFFObject.cpp
  llvm/lib/ObjCopy/COFF/COFFObject.h
  llvm/lib/ObjCopy/COFF/COFFReader.cpp
  llvm/lib/ObjCopy/COFF/COFFReader.h
  llvm/lib/ObjCopy/COFF/COFFWriter.cpp
  llvm/lib/ObjCopy/COFF/COFFWriter.h
  llvm/lib/ObjCopy/CopyConfig.cpp
  llvm/lib/ObjCopy/ELF/ELFConfig.cpp
  llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
  llvm/lib/ObjCopy/ELF/ELFObject.cpp
  llvm/lib/ObjCopy/ELF/ELFObject.h
  llvm/lib/ObjCopy/LLVMBuild.txt
  llvm/lib/ObjCopy/MachO/MachOLayoutBuilder.cpp
  llvm/lib/ObjCopy/MachO/MachOLayoutBuilder.h
  llvm/lib/ObjCopy/MachO/MachOObjcopy.cpp
  llvm/lib/ObjCopy/MachO/MachOObject.cpp
  llvm/lib/ObjCopy/MachO/MachOObject.h
  llvm/lib/ObjCopy/MachO/MachOReader.cpp
  llvm/lib/ObjCopy/MachO/MachOReader.h
  llvm/lib/ObjCopy/MachO/MachOWriter.cpp
  llvm/lib/ObjCopy/MachO/MachOWriter.h
  llvm/lib/ObjCopy/ObjCopy.cpp
  llvm/lib/ObjCopy/Util.h
  llvm/lib/ObjCopy/wasm/WasmObjcopy.cpp
  llvm/lib/ObjCopy/wasm/WasmObject.cpp
  llvm/lib/ObjCopy/wasm/WasmObject.h
  llvm/lib/ObjCopy/wasm/WasmReader.cpp
  llvm/lib/ObjCopy/wasm/WasmReader.h
  llvm/lib/ObjCopy/wasm/WasmWriter.cpp
  llvm/lib/ObjCopy/wasm/WasmWriter.h
  llvm/tools/llvm-objcopy/Buffer.cpp
  llvm/tools/llvm-objcopy/Buffer.h
  llvm/tools/llvm-objcopy/CMakeLists.txt
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.h
  llvm/tools/llvm-objcopy/COFF/Object.cpp
  llvm/tools/llvm-objcopy/COFF/Object.h
  llvm/tools/llvm-objcopy/COFF/Reader.cpp
  llvm/tools/llvm-objcopy/COFF/Reader.h
  llvm/tools/llvm-objcopy/COFF/Writer.cpp
  llvm/tools/llvm-objcopy/COFF/Writer.h
  llvm/tools/llvm-objcopy/CopyConfig.cpp
  llvm/tools/llvm-objcopy/CopyConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFConfig.cpp
  llvm/tools/llvm-objcopy/ELF/ELFConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.h
  llvm/tools/llvm-objcopy/ELF/Object.cpp
  llvm/tools/llvm-objcopy/ELF/Object.h
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.h
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.h
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
  llvm/tools/llvm-objcopy/MachO/MachOReader.h
  llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.h
  llvm/tools/llvm-objcopy/MachO/Object.cpp
  llvm/tools/llvm-objcopy/MachO/Object.h
  llvm/tools/llvm-objcopy/ParseConfig.cpp
  llvm/tools/llvm-objcopy/ParseConfig.h
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.h
  llvm/tools/llvm-objcopy/wasm/Object.cpp
  llvm/tools/llvm-objcopy/wasm/Object.h
  llvm/tools/llvm-objcopy/wasm/Reader.cpp
  llvm/tools/llvm-objcopy/wasm/Reader.h
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.h
  llvm/tools/llvm-objcopy/wasm/Writer.cpp
  llvm/tools/llvm-objcopy/wasm/Writer.h
  llvm/unittests/CMakeLists.txt
  llvm/unittests/ObjCopy/CMakeLists.txt
  llvm/unittests/ObjCopy/ObjCopyTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88827.299664.patch
Type: text/x-patch
Size: 77501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201021/067ca6ab/attachment-0001.bin>


More information about the llvm-commits mailing list