[PATCH] D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 updated this revision to Diff 299655.
cchen15 marked 2 inline comments as done.
cchen15 added a comment.

Per review comments, fixed/enhanced the description of createArrayType.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89817/new/

https://reviews.llvm.org/D89817

Files:
  llvm/include/llvm/IR/DIBuilder.h
  llvm/lib/IR/DIBuilder.cpp


Index: llvm/lib/IR/DIBuilder.cpp
===================================================================
--- llvm/lib/IR/DIBuilder.cpp
+++ llvm/lib/IR/DIBuilder.cpp
@@ -527,10 +527,15 @@
 
 DICompositeType *DIBuilder::createArrayType(uint64_t Size,
                                             uint32_t AlignInBits, DIType *Ty,
-                                            DINodeArray Subscripts) {
+                                            DINodeArray Subscripts,
+                                            Metadata *DataLocation,
+                                            Metadata *Associated,
+                                            Metadata *Allocated) {
   auto *R = DICompositeType::get(VMContext, dwarf::DW_TAG_array_type, "",
                                  nullptr, 0, nullptr, Ty, Size, AlignInBits, 0,
-                                 DINode::FlagZero, Subscripts, 0, nullptr);
+                                 DINode::FlagZero, Subscripts, 0, nullptr,
+                                 nullptr, "", nullptr, DataLocation,
+                                 Associated, Allocated);
   trackIfUnresolved(R);
   return R;
 }
Index: llvm/include/llvm/IR/DIBuilder.h
===================================================================
--- llvm/include/llvm/IR/DIBuilder.h
+++ llvm/include/llvm/IR/DIBuilder.h
@@ -494,8 +494,14 @@
     /// \param AlignInBits  Alignment.
     /// \param Ty           Element type.
     /// \param Subscripts   Subscripts.
+    /// \param DataLocation Where to find the raw data of a Fortran array
+    /// \param Associated   Where to find the associated attribute of a Fortran array.
+    /// \param Allocated    Where to find the allocated attribute of a Fortran array.
     DICompositeType *createArrayType(uint64_t Size, uint32_t AlignInBits,
-                                     DIType *Ty, DINodeArray Subscripts);
+                                     DIType *Ty, DINodeArray Subscripts,
+                                     Metadata *DataLocation = nullptr,
+                                     Metadata *Associated = nullptr,
+                                     Metadata *Allocated = nullptr);
 
     /// Create debugging information entry for a vector type.
     /// \param Size         Array size.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89817.299655.patch
Type: text/x-patch
Size: 2265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201021/59fc0630/attachment.bin>