[PATCH] D89841: [ELF] --gc-sections: retain dependent sections of non-SHF_ALLOC sections

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 05:46:53 PDT 2020


grimar accepted this revision.
grimar added a comment.

LGTM too.



================
Comment at: lld/ELF/MarkLive.cpp:368
   // - Groups members are retained or discarded as a unit.
   for (InputSectionBase *sec : inputSections) {
     bool isAlloc = (sec->flags & SHF_ALLOC);
----------------
nit: perhaps worth updating this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89841/new/

https://reviews.llvm.org/D89841



More information about the llvm-commits mailing list