[llvm] d4d0b41 - [X86] Remove period from end of error message in assembler

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 00:43:43 PDT 2020


Author: Craig Topper
Date: 2020-10-21T00:43:23-07:00
New Revision: d4d0b41a822bacffa42ecea3c0f4c6980463dd31

URL: https://github.com/llvm/llvm-project/commit/d4d0b41a822bacffa42ecea3c0f4c6980463dd31
DIFF: https://github.com/llvm/llvm-project/commit/d4d0b41a822bacffa42ecea3c0f4c6980463dd31.diff

LOG: [X86] Remove period from end of error message in assembler

Addresses post-commit feedback from D89837.

Added: 
    

Modified: 
    llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
    llvm/test/MC/X86/encoder-fail.s

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
index cb08b7de9afb..7fd93cff692e 100644
--- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -3640,7 +3640,7 @@ bool X86AsmParser::validateInstruction(MCInst &Inst, const OperandVector &Ops) {
       StringRef RegName = X86IntelInstPrinter::getRegisterName(HReg);
       return Error(Ops[0]->getStartLoc(),
                    "can't encode '" + RegName + "' in an instruction requiring "
-                   "REX prefix.");
+                   "REX prefix");
     }
   }
 

diff  --git a/llvm/test/MC/X86/encoder-fail.s b/llvm/test/MC/X86/encoder-fail.s
index 2ca74a41c914..a8b9f48c8fb7 100644
--- a/llvm/test/MC/X86/encoder-fail.s
+++ b/llvm/test/MC/X86/encoder-fail.s
@@ -1,16 +1,16 @@
 // RUN: not llvm-mc -triple x86_64-unknown-unknown --show-encoding %s 2>&1 | FileCheck %s
 
-// CHECK: error: can't encode 'dh' in an instruction requiring REX prefix.
+// CHECK: error: can't encode 'dh' in an instruction requiring REX prefix
 movzx %dh, %rsi
 
-// CHECK: error: can't encode 'ah' in an instruction requiring REX prefix.
+// CHECK: error: can't encode 'ah' in an instruction requiring REX prefix
 movzx %ah, %r8d
 
-// CHECK: error: can't encode 'bh' in an instruction requiring REX prefix.
+// CHECK: error: can't encode 'bh' in an instruction requiring REX prefix
 add %bh, %sil
 
-// CHECK: error: can't encode 'ch' in an instruction requiring REX prefix.
+// CHECK: error: can't encode 'ch' in an instruction requiring REX prefix
 mov %ch, (%r8)
 
-// CHECK: error: can't encode 'dh' in an instruction requiring REX prefix.
+// CHECK: error: can't encode 'dh' in an instruction requiring REX prefix
 mov %dh, (%rax,%r8)


        


More information about the llvm-commits mailing list