[PATCH] D89713: [llvm-objcopy] extract arg parsing logic to function

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 00:42:54 PDT 2020


jhenderson added a comment.

In D89713#2341106 <https://reviews.llvm.org/D89713#2341106>, @jhenderson wrote:

> Looks good, with one suggestion.
>
> Also, couple of notes about the summary:
>
> 1. Add `[NFC]` to the summary, as there is no functional change caused by this patch.
> 2. Tags tend to be in the form `[llvm-objcopy]` etc.

Summary == patch/commit title, i.e. the full title should be "[llvm-objcopy][NFC] extract arg parsing logic to function" (or something like that).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89713/new/

https://reviews.llvm.org/D89713



More information about the llvm-commits mailing list