[PATCH] D89800: [ARM][LowOverheadLoops] Don't generate a LOL if lr is redefined after the start

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 00:42:12 PDT 2020


dmgreen added a comment.

I think we may need to alter the way this works to make it so that things like this ideally can't happen. I've been trying to change it so that t2LoopStart looks like:

  $lr = t2DoLoopStart renamable $rn

as opposed to

  t2DoLoopStart renamable $rn

That I hope should glue this together better and mean that we can rely on lr always being the correct value to use at least at the start instruction, and we don't need to revert as often. But there are a lot of tests to update :-/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89800/new/

https://reviews.llvm.org/D89800



More information about the llvm-commits mailing list