[PATCH] D89798: [SVE][AArch64] Fix TypeSize warning in loop vectorization legality

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-scalable-load-in-loop.ll:3
+; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
+
+; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it.
----------------
sdesmalen wrote:
> Can you add a description of what this test is supposed to be testing?
> 
> Given that there are no CHECK lines that verify the output of `opt`, you may as well leave the first call to FileCheck out.
There is a CHECK-LABEL line below. but I think if you keep the first FileCheck then it's good to add at least one more CHECK line, perhaps something like:

; CHECK-NOT: vector.body

? I've seen other tests do something similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89798/new/

https://reviews.llvm.org/D89798