[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange

Alok Kumar Sharma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 23:19:38 PDT 2020


alok marked an inline comment as done.
alok added a comment.

In D89218#2335920 <https://reviews.llvm.org/D89218#2335920>, @aprantl wrote:

> Cab you remind me why we are allowing ConstantAsMetadata nodes at all instead of allowing only DIExpressions?

Assumed rank is relatively new as well as advance feature in Fortran. It looks like DIExpression should be enough currently with the current understanding. One way is to start with DIExpression only and keep adding other types as and when needed (with addition to feature), but I kept it generalized to keep the representation of bounds rich as well as similar to usual array bounds (with permissible types).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89218/new/

https://reviews.llvm.org/D89218



More information about the llvm-commits mailing list