[PATCH] D80695: [mlir] Convert raw data in dense element attributes for big-endian machines.

[Haruki Imai via Phabricator via llvm-commits]

imaihal marked an inline comment as done.
imaihal added inline comments.


================
Comment at: mlir/lib/Support/EndianUtilities.cpp:44
+
+void mlir::convEndianBE(ArrayRef<char> inRawData,
+                        MutableArrayRef<char> outRawData, ShapedType type) {
----------------
rriddle wrote:
> Can you just make this a utility method on DenseIntOrFpElementsAttr itself? This removes the duplicated code, and also removes the need to break library layering by having Support/ depend on IR/.
Thanks for your review. I moved it to `DenseIntOrFPElementsAttr `. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80695/new/

https://reviews.llvm.org/D80695