[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:29
 
+static constexpr uint32_t INVALID_REGNUM = UINT32_MAX;
+
----------------
Delete 'static': const and constexpr in the namespace scope is of internal linkage and thus implicitly 'static'. 


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:57
+  Location Kind;   // The type of the location that describes how to unwind it.
+  uint32_t RegNum; // The register number for Kind == RegPlusOffset.
+  int32_t Offset;  // The offset for Kind == CFAPlusOffset or RegPlusOffset.
----------------
Might be easier using member initializers for these variables of non-class types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845