[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 19:09:17 PDT 2020


dexonsmith added a comment.

In D85474#2343326 <https://reviews.llvm.org/D85474#2343326>, @MaskRay wrote:

> In D85474#2342365 <https://reviews.llvm.org/D85474#2342365>, @compnerd wrote:
>
>> Is there a reason to not use the existing `-mlinker-version=` option and expanding that beyond just Darwin targets?  I feel like having the same option would be much nicer.

I agree with @compnerd that it seems better to reuse this if possible. I wasn't around back then, but I have to assume it was named generically in order to enable that.

> `-mlinker-version` is currently a macOS option. We could reuse it but that would be confusing: when -fuse-ld=lld is specified, does it specify the lld version? (No)

Maybe it should?

> There are also GNU as related issues.

I don't understand this bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85474/new/

https://reviews.llvm.org/D85474



More information about the llvm-commits mailing list