[PATCH] D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 16:00:39 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5730
+ // Check defs of LR.
+ if (MI.modifiesRegister(ARM::LR, nullptr))
+ Live = false;
----------------
chill wrote:
> yroux wrote:
> > I think we can get ride of passing nullptr since it is TRI default value in the prototype
> One would think so, wouldn't they? :D
>
> I created D89625
If you omit TRI, you'll miss defs of super-registers of LR. I'm not sure there are any at the moment, but there are for other GPRs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89189/new/
https://reviews.llvm.org/D89189
More information about the llvm-commits
mailing list