[PATCH] D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 14:56:04 PDT 2020


jmorse added a comment.

In D89088#2342922 <https://reviews.llvm.org/D89088#2342922>, @jmorse wrote:

> If an entry block with a predecessor is legal behaviour [...]

NB: the LLVM-IR langref section for functions states:

  The first basic block in a function is special in two ways: it is immediately executed on entrance to the function, and it is not allowed to have predecessor basic blocks (i.e. there can not be any branches to the entry block of a function). Because the block can have no predecessors, it also cannot have any PHI nodes.

I'd lean towards the input Machine-IR to LiveDebugValues being incorrect here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89088/new/

https://reviews.llvm.org/D89088



More information about the llvm-commits mailing list