[PATCH] D89632: [DomTree] Accept Value as Def (NFC)
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 13:48:44 PDT 2020
kuhar accepted this revision.
kuhar added a comment.
Thanks for updating the comments.
One corner case: how does dominance work over global values (possibly with initializers)? Is it possible to have invalid IR where a global has a broken initializer, but `dominates` answers `true`? I don't know this part of IR very well and am not sure if such issues are possible or not.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89632/new/
https://reviews.llvm.org/D89632
More information about the llvm-commits
mailing list