[PATCH] D89818: [Compile Time] Make it possible to skip redundant debuginst removal

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Is this an NFC patch? If not, can you please add a test case?



================
Comment at: llvm/include/llvm/Transforms/Utils/BasicBlockUtils.h:93
 /// successor Sing. In this case the branch will be updated with Sing instead of
 /// BB, and BB will still be merged into its predecessor and removed.
 bool MergeBlockIntoPredecessor(BasicBlock *BB, DomTreeUpdater *DTU = nullptr,
----------------
please document under what circumstances one would pass true to the last two parameters


================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:867
+      if (MergeBlockIntoPredecessor(Dest, &DTU, LI, nullptr, nullptr, false,
+                                    true)) {
         // Dest has been folded into Fold. Update our worklists accordingly.
----------------
please add a comment that explains why passing true is correct/needed/right here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89818/new/

https://reviews.llvm.org/D89818