[PATCH] D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Can you also add a unit test for this?



================
Comment at: llvm/include/llvm/IR/DIBuilder.h:497
     /// \param Subscripts   Subscripts.
+    /// \param DataLocation Where to find the raw data of a Fortran array
+    /// \param Associated   Where to find the associated attribute of a Fortran array.
----------------
nit: `.` at the end please


================
Comment at: llvm/include/llvm/IR/DIBuilder.h:498
+    /// \param DataLocation Where to find the raw data of a Fortran array
+    /// \param Associated   Where to find the associated attribute of a Fortran array.
+    /// \param Allocated    Where to find the allocated attribute of a Fortran array.
----------------
Please also document what kind of DINode is expected here.


================
Comment at: llvm/include/llvm/IR/DIBuilder.h:502
+                                     DIType *Ty, DINodeArray Subscripts,
+                                     Metadata *DataLocation = nullptr,
+                                     Metadata *Associated = nullptr,
----------------
Can these be any more specific DINode types?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89817/new/

https://reviews.llvm.org/D89817