[PATCH] D88735: [SLP] Also try to vectorize incoming values of PHIs .
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 20 12:58:46 PDT 2020
ABataev added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7608-7612
+ // There's no need to try to vectorize incoming values from the current
+ // BB, because the instructions in BB will be considered for
+ // vectorization directly.
+ if (BB == P->getIncomingBlock(I))
+ continue;
----------------
The comment is not quite correct, I think. The instructions from the current block would not necessarily be considered for vectorization, we still may miss them. That's why I said that it would be good to gather these instructions into a container and then process them after the end of the processing of the current block if they were not vectorized(deleted) yet.
This can be implemented later, just need to improve the comment and add a TODO to implement delayed vectorization for the incoming values from the current block.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88735/new/
https://reviews.llvm.org/D88735
More information about the llvm-commits
mailing list