[PATCH] D89788: [RISCV] Add GHC calling convention

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/ghc-cc.ll:1-3
+; RUN: llc -mtriple=riscv64-unknown-linux-gnu -mattr=+f,+d \
+; RUN:   --target-abi lp64d < %s \
+; RUN:   | FileCheck %s
----------------
schwab wrote:
> jrtc27 wrote:
> > Please make this match the other tests in here, ie:
> > - match the llc invocation style
> > - test both rv32 and rv64
> > - use update_llc_test_checks.py
> How can I parameterize the types on the triple?
Hm right you'd need i32. We pipe things through sed in our fork to `s/\<iXLEN\>/i64/` etc but I don't think the upstream update_llc_test_checks.py likes that (though maybe it does these days?). You'd have to duplicate the file otherwise as is done for calling-conv-ilp32.ll and calling-conv-lp64.ll.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89788/new/

https://reviews.llvm.org/D89788