[PATCH] D83088: Introduce CfgTraits abstraction

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 09:56:42 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/Dominance.h:49
+template <>
+struct llvm::CfgTraitsFor<mlir::Block> {
+  using CfgTraits = mlir::CfgTraits;
----------------
This seems to have broken the GCC5 build:
https://buildkite.com/mlir/mlir-core/builds/8739#7a957564-9850-487c-a814-c6818890bd14

```
/mlir/include/mlir/IR/Dominance.h:49:14: error: specialization of 'template<class CfgRelatedTypeT> struct llvm::CfgTraitsFor' in different namespace [-fpermissive]
 struct llvm::CfgTraitsFor<mlir::Block> {
              ^
In file included from mlir/include/mlir/IR/Dominance.h:13:0,
                 from mlir/lib/IR/Verifier.cpp:30:
llvm/include/llvm/Support/CfgTraits.h:294:44: error:   from definition of 'template<class CfgRelatedTypeT> struct llvm::CfgTraitsFor' [-fpermissive]
 template <typename CfgRelatedTypeT> struct CfgTraitsFor;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83088/new/

https://reviews.llvm.org/D83088



More information about the llvm-commits mailing list