[PATCH] D89781: [NPM] Port -mergereturn to NPM

Ta-Wei Tu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 09:56:33 PDT 2020


TaWeiTu marked an inline comment as done.
TaWeiTu added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/UnifyFunctionExitNodes.cpp:125
+                                                  FunctionAnalysisManager &AM) {
+  if (!unifyUnreachableBlocks(F) && !unifyReturnBlocks(F))
+    return PreservedAnalyses::all();
----------------
aeubanks wrote:
> this won't run `unifyReturnBlocks()` if `unifyUnreachableBlocks()` returns true, is that expected?
Oh, that was stupid. Thanks for pointing it out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89781/new/

https://reviews.llvm.org/D89781



More information about the llvm-commits mailing list