[PATCH] D89390: [TargetLowering] Update optimization to check for boolean content

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 09:40:20 PDT 2020


spatel added a comment.

In D89390#2341768 <https://reviews.llvm.org/D89390#2341768>, @ErikHogeman wrote:

> In D89390#2341731 <https://reviews.llvm.org/D89390#2341731>, @spatel wrote:
>
>> LGTM - although it would be nicer to add the test first (without this patch), so we see the difference in output.
>
> Ah right, I assumed it would be fine since the instruction diff will be visible in the next patch I will upload. 
> If you prefer it I can submit the test first and then the patch as a follow-up, and then a third commit that improves the condition.

Yeah, I like the layered commits, so it's clear how the code is changing with the compiler change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89390/new/

https://reviews.llvm.org/D89390



More information about the llvm-commits mailing list