[PATCH] D89548: [SCEV] Prove implications of different type via truncation

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! As mentioned inline, I think it would be good to have a fix for the  issue pointed out ready before the change goes in.



================
Comment at: llvm/test/Analysis/ScalarEvolution/srem.ll:32
 ; CHECK-NEXT:    %inc = add nsw i32 %i.0, 1
-; CHECK-NEXT:    --> {1,+,1}<nuw><%for.cond> U: [1,0) S: [1,0) Exits: (1 + %width) LoopDispositions: { %for.cond: Computable }
+; CHECK-NEXT:    --> {1,+,1}<nuw><%for.cond> U: full-set S: full-set Exits: (1 + %width) LoopDispositions: { %for.cond: Computable }
 ; CHECK-NEXT:  Determining loop execution counts for: @_Z4loopi
----------------
mkazantsev wrote:
> mkazantsev wrote:
> > Bug in underpying patch.
> It happens just because we create zero extend SCEV (and not proving further ule). A subject for a follow-up fix.
It would probably be good to have a fix lined up before this goes in


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89548/new/

https://reviews.llvm.org/D89548