[PATCH] D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 08:14:44 PDT 2020


dmgreen added a comment.

Hello. You probably need a to mark MULH's as expand:

  setOperationAction(ISD::MULHU, MVT::i16, Expand);
  setOperationAction(ISD::MULHS, MVT::i16, Expand);

(Or if there is a suitable instruction, it can be lowered to that, but the fix above is probably best in the sort term.)

I see this is done for i64's and vectors, but not for other types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80485/new/

https://reviews.llvm.org/D80485



More information about the llvm-commits mailing list