[PATCH] D89378: [LoopFlatten] Loop limit invariant checks

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 07:37:53 PDT 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/LoopFlatten/limit-not-invariant.ll:14
 ; CHECK-NEXT:    [[CONV4:%.*]] = sext i16 [[VAL:%.*]] to i32
+; CHECK-NEXT:    [[WIDE_TRIP_COUNT:%.*]] = zext i32 [[N]] to i64
 ; CHECK-NEXT:    br label [[FOR_COND1_PREHEADER_US:%.*]]
----------------
dmgreen wrote:
> These tests don't then flatten?
Well spotted. This patch was part of my grand master plan to support different phi types, and this patch was to get the first little obstacle out of the way. But because of changes in D88880, the input IR and test case might not be so relevant anymore, so I will look at that first now because I still think this is little change is useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89378/new/

https://reviews.llvm.org/D89378



More information about the llvm-commits mailing list