[PATCH] D89501: [AMDGPU] flat scratch ST addressing mode on gfx10

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1140-1141
 
+def HasFlatScratchSTMode : Predicate<"Subtarget->hasFlatScratchSTMode()">,
+  AssemblerPredicate<(any_of FeatureGFX10_3Insts)>;
+
----------------
foad wrote:
> I think technically the assembler/disassembler support should be in GFX10.1, it's just that we don't want the compiler to generate them until GFX10.3 because of hardware bugs. Maybe at least add a comment explaining why the predicate is FeatureGFX10_3Insts here?
Given the errata there is no difference to Vega. It was possible to encode off/off from start. It just plain does not work and no point to support or allow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89501/new/

https://reviews.llvm.org/D89501