[PATCH] D89170: [AMDGPU] Select flat scratch instructions where available

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1691
+  unsigned AS = findMemSDNode(N)->getAddressSpace();
+  if (!Subtarget->enableFlatScratch() && AS == AMDGPUAS::PRIVATE_ADDRESS)
+    return false;
----------------
Swap these?


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1449
+
+        Register TmpReg = RS->scavengeRegister(RC, MI, 0);
+        FIOp.setReg(TmpReg);
----------------
What happens if this needs an SGPR spill?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89170/new/

https://reviews.llvm.org/D89170