[PATCH] D89501: [AMDGPU] flat scratch ST addressing mode on gfx10

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 06:16:00 PDT 2020

Previous message: [PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O
Next message: [PATCH] D89501: [AMDGPU] flat scratch ST addressing mode on gfx10
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

foad added a comment.

LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:239
+  bit EnableSaddr = 0,
+  bit EnableVaddr = !if(EnableSaddr, 0, 1)>
+  : FLAT_Pseudo<
----------------
Use `!not`? See D89331.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89501/new/

https://reviews.llvm.org/D89501

Previous message: [PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O
Next message: [PATCH] D89501: [AMDGPU] flat scratch ST addressing mode on gfx10
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list