[PATCH] D88540: [AMDGPU] Add amdgpu_gfx_callable calling convention

[Sebastian Neubauer via Phabricator via llvm-commits]

Flakebi added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/unsupported-calls.ll:72
 
-; GCN: :0:0: in function test_call_from_shader i32 (): unsupported call from graphics shader of function defined_function
+; GCN-NOT: :0:0: in function test_call_from_shader i32 (): unsupported call from graphics shader of function defined_function
 ; R600: in function test_call{{.*}}: unsupported call to function defined_function
----------------
arsenm wrote:
> This is very fragile negative check.
> 
> It's also questionable if this should be allowed to call C calling conventions. It would need an FP mode switch since the default IEEE mode bit is different (although it's currently not the backend's responsibility to insert it)
C calling convention is now disallowed. I made the check more generic but I didn’t find a great way to make it a positive check that would not break checks for the other test functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88540/new/

https://reviews.llvm.org/D88540