[PATCH] D89787: [AsmParser] Add source location to all errors related to .cfi directives

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
arichardson added reviewers: rnk, kristina.
Herald added subscribers: llvm-commits, hiraditya, krytarowski, emaste.
Herald added a project: LLVM.
arichardson requested review of this revision.

I was trying to add .cfi_ annotations to assembly code in the FreeBSD
kernel and changed a macro that then resulted in incorrectly nested
directives. However, clang's diagnostics said the error was happening at
<unknown>:0, so this patch requires a SMLoc to be passed along to all
callers of MCStreamer::getCurrentDwarfFrameInfo(). This addresses one of
the TODOs added in D51695 <https://reviews.llvm.org/D51695>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89787

Files:
  llvm/include/llvm/MC/MCStreamer.h
  llvm/lib/CodeGen/AsmPrinter/ARMException.cpp
  llvm/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCFIException.cpp
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
  llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  llvm/lib/Target/X86/X86MCInstLower.cpp
  llvm/test/MC/X86/cfi-open-within-another-crash.s
  llvm/test/MC/X86/cfi-scope-errors.s
  llvm/test/MC/X86/cfi-scope-unclosed.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89787.299331.patch
Type: text/x-patch
Size: 56733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201020/2c13e666/attachment-0001.bin>