[PATCH] D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler

[elena via Phabricator via llvm-commits]

ekovanov added a subscriber: clayborg.
ekovanov added a comment.

Hi @clayborg !

There are several failed tests for both Linux and Windows in "Build Status" section of this review.
The vast majority of failed tests is related to lldb.

But I wouldn’t expect my commit to have any effect unless -DLLVM_USE_INTEL_JITEVENTS=ON is used.
(the option -DLLVM_USE_INTEL_JITEVENTS=ON does not participate in build process on Phabricator)

I tried to run failed tests with applied diff on my system and tests have passed. (master from 9th September)

Do you think that tests failures are related to my commit?

Number of failed tests is unstable(multiple revisions of this patch), but there are consistently repeating items:

40 tests on Linux:

  lldb-api :: commands/expression/import-std-module/basic/TestImportStdModule.py
  lldb-api :: commands/expression/import-std-module/conflicts/TestStdModuleWithConflicts.py
  lldb-api :: commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
  lldb-api :: commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
  lldb-api :: commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
  lldb-api :: commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
  lldb-api :: commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py
  lldb-api :: commands/expression/import-std-module/list/TestListFromStdModule.py
  lldb-api :: commands/expression/import-std-module/no-std-module/TestMissingStdModule.py
  lldb-api :: commands/expression/import-std-module/queue/TestQueueFromStdModule.py
  lldb-api :: commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
  lldb-api :: commands/expression/import-std-module/shared_ptr/TestSharedPtrFromStdModule.py
  lldb-api :: commands/expression/import-std-module/stack/TestStackFromStdModule.py
  lldb-api :: commands/expression/import-std-module/unique_ptr-dbg-info-content/TestUniquePtrDbgInfoContent.py
  lldb-api :: commands/expression/import-std-module/unique_ptr/TestUniquePtrFromStdModule.py
  lldb-api :: commands/expression/import-std-module/vector-bool/TestVectorBoolFromStdModule.py
  lldb-api :: commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py
  lldb-api :: commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
  lldb-api :: commands/expression/import-std-module/vector/TestVectorFromStdModule.py
  lldb-api :: commands/expression/import-std-module/weak_ptr-dbg-info-content/TestDbgInfoContentWeakPtrFromStdModule.py
  lldb-api :: commands/expression/import-std-module/weak_ptr/TestWeakPtrFromStdModule.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/bitset/TestDataFormatterLibcxxBitset.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/forward_list/TestDataFormatterLibcxxForwardList.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/list/loop/TestDataFormatterLibcxxListLoop.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/multimap/TestDataFormatterLibccMultiMap.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/multiset/TestDataFormatterLibcxxMultiSet.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/queue/TestDataFormatterLibcxxQueue.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/set/TestDataFormatterLibcxxSet.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/tuple/TestDataFormatterLibcxxTuple.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/unordered/TestDataFormatterUnordered.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/vbool/TestDataFormatterLibcxxVBool.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/vector/TestDataFormatterLibcxxVector.py
  lldb-api :: lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py

25 tests on Windows:

  Profile-x86_64 :: gcc-flag-compatibility.test
  Profile-x86_64 :: instrprof-override-filename.c
  cfi-standalone-lld-thinlto-x86_64 :: stats.cpp
  cfi-standalone-lld-x86_64 :: stats.cpp
  debuginfo-tests :: dexter/feature_tests/unittests/run.test
  libomp :: affinity/format/affinity_values.c
  libomp :: affinity/format/fields_values.c
  libomp :: tasking/bug_nested_proxy_task.c
  libomp :: tasking/bug_proxy_task_dep_waiting.c
  lldb-shell :: SymbolFile/NativePDB/stack_unwinding01.cpp
  lldb-shell :: SymbolFile/PDB/ast-restore.test
  lldb-shell :: SymbolFile/PDB/class-layout.test
  lldb-shell :: SymbolFile/PDB/enums-layout.test
  lldb-shell :: SymbolFile/PDB/typedefs.test
  lldb-shell :: SymbolFile/PDB/variables.test
  lldb-unit :: Utility/./UtilityTests.exe/PassiveReplayTest.InstrumentedBar
  lldb-unit :: Utility/./UtilityTests.exe/PassiveReplayTest.InstrumentedBarPtr
  lldb-unit :: Utility/./UtilityTests.exe/PassiveReplayTest.InstrumentedBarRef
  lldb-unit :: Utility/./UtilityTests.exe/PassiveReplayTest.InstrumentedFoo
  lldb-unit :: Utility/./UtilityTests.exe/PassiveReplayTest.InstrumentedFooInvalid
  lldb-unit :: Utility/./UtilityTests.exe/RecordReplayTest.InstrumentedBar
  lldb-unit :: Utility/./UtilityTests.exe/RecordReplayTest.InstrumentedBarPtr
  lldb-unit :: Utility/./UtilityTests.exe/RecordReplayTest.InstrumentedBarRef
  lldb-unit :: Utility/./UtilityTests.exe/RecordReplayTest.InstrumentedFoo
  lldb-unit :: Utility/./UtilityTests.exe/RecordReplayTest.InstrumentedFooSameThis

Thank you in advance!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86435/new/

https://reviews.llvm.org/D86435