[PATCH] D89605: Add -prepend_rpath install-name-tool option

Tue Oct 20 02:57:00 PDT 2020

alexshap added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-prepend-rpath.test:35-38
+# RUN: not llvm-install-name-tool -prepend_rpath @executable_path/. 2>&1 \
+# RUN: | FileCheck --check-prefix=NO-INPUT %s
+
+# NO-INPUT: no input file specified
----------------
jhenderson wrote:
> This isn't a test case that's needed here - the behaviour for "no input file" is not specific to the new option, and is (or should be at least) tested elsewhere.
@jhenderson is right, this is covered by https://github.com/llvm/llvm-project-staging/blob/staging/apple/llvm/test/tools/llvm-objcopy/tool-help-message.test (see NO-INPUT-FILES, MULTIPLE-INPUT-FILES, UNKNOWN-ARG).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89605/new/

https://reviews.llvm.org/D89605