[PATCH] D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:226-239
+    return true;
+  }
+
+  bool Pre(const parser::OpenMPDeclarativeConstruct &x) {
+    std::visit(common::visitors{
+                   [&](const parser::OpenMPThreadprivate &construct) {
+                     if (Pre(construct))
----------------
praveen wrote:
> kiranchandramohan wrote:
> > Why is this change required?
> @kiranchandramohan  This change is required to identify the list items present on the OpenMPThreadprivate directive as the semantic checks for the declarative directives are not yet implemented at present . 
I didn't check this in detail. By default, the walk should visit all kinds of nodes including Threadprivate and the code in Pre(threadprivate) processes the list of variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89385/new/

https://reviews.llvm.org/D89385