[PATCH] D76879: [AMDGPU] Begin emitting CFI for AMDGCN

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu added inline comments.


================
Comment at: llvm/test/MC/ELF/AMDGPU/cfi.s:13
+# ASM-NEXT: .cfi_sections .debug_frame
+# FIXME Why emit an extra empty line?
+# ASM-EMPTY:
----------------
greened wrote:
> Are these intended to be fixed before merge or is the test just nothing something should be fixed?  If the latter, perhaps we need an XFAIL test for it?  But maybe it's not worth it.
Currently the AsmParser is not skipping the '\n' i.e. EndOfStatement at the end while parsing the asm directives and hence the extra new line is being generated for that '\n'.

And the above behavior is not a result of any of the patch in this patch series.
May be the FIXME here can be changed to a note indicating that the blank line is required and/or expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76879/new/

https://reviews.llvm.org/D76879